-
Notifications
You must be signed in to change notification settings - Fork 22
Python3 migration #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jay07GIT
wants to merge
8
commits into
vinyldns:master
Choose a base branch
from
Jay07GIT:python3_migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay07GIT <jeyraj931@gmail.com>
Signed-off-by: Jay07GIT <jeyraj931@gmail.com>
Sokitha-21
approved these changes
Dec 24, 2025
JoshSEdwards
requested changes
Dec 29, 2025
JoshSEdwards
approved these changes
Jan 2, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed -- looks good now. Just need to remember to add the CODECOV_TOKEN to the repo's Actions Secrets before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/core
This issue/PR affects the core functionality
area/dependencies
This issue/PR affects dependencies
kind/maintenance
Code cleanup, refactoring, tech debt, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the PR.
Removed legacy Python-2 compatibility, upgrading AWS dependencies(boto to boto 3), and introducing GitHub Actions for run tests and code coverage.
To test the PR-
Run ->
tox -e check,py3To test the github actions -
Run ->
actTo test the PR with vinyldns API
To import the PR Branch use this in the requirement.txt
git+https://github.com/Jay07Git/vinyldns-python.git@python3_migration#egg=vinyldns-pythonCreate a new python file and use a below code to test- List zones from vinyldns